drivers: memc: siwx91x: Fix performances #97254
Merged
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_silabs
DNM (manifest)
zephyrbot
requested review from
Martinhoff-maker,
asmellby,
jhedberg,
nordic-krch,
rettichschnidi and
yonsch
asmellby
previously approved these changes
Oct 9, 2025
Martinhoff-maker
previously approved these changes
Oct 9, 2025
fimohame
approved these changes
Oct 14, 2025
jerome-pouiller
dismissed stale reviews from Martinhoff-maker and asmellby
via
1249844
jerome-pouiller
force-pushed
the
fix-psram
branch
from
1bce793 to
1249844
Compare
PSRAMSecureSegments is in fact orphan. Signed-off-by: Jérôme Pouiller <[email protected]>
In the original HAL, sl_si91x_psram_init() and sl_si91x_psram_uninit() were also in charge of configuring the pinctrl and the clocks. A workaround have been introduced to avoid change in pinctrl but they still changed the clock configuration. We definitely need to expose the clock configuration to Zephyr users. The HAL has been patched to split the sl_si91x_psram_*init() function in smaller pieces. So it is possible to configure the devic without changing the clock or the pinctrl. Let's use these new functions. Signed-off-by: Jérôme Pouiller <[email protected]>
Siwx91x memory controller is currently 4 times slower than expected. Investigations point out the clock is not correct. Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
force-pushed
the
fix-psram
branch
from
1249844 to
5c4f6a5
Compare
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
LucasTambor,
Vge0rge,
d3zd3z,
ithinuel,
sylvioalves,
tomi-font,
valeriosetti and
wearyzen
github-actions
bot
removed
DNM (manifest)
|
jhedberg
approved these changes
Oct 14, 2025
Martinhoff-maker
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siwx91x memory controller is currently 4 times slower than expected. Investigations point out the clock is not correct.
CC: @fimohame